Only use non-server generated events for max rev setting#3776
Merged
marcellamaki merged 3 commits intolearningequality:hotfixesfrom Oct 28, 2022
Merged
Only use non-server generated events for max rev setting#3776marcellamaki merged 3 commits intolearningequality:hotfixesfrom
marcellamaki merged 3 commits intolearningequality:hotfixesfrom
Conversation
This will lead to occasional repeated change event fetching.
marcellamaki
approved these changes
Oct 28, 2022
Member
marcellamaki
left a comment
marcellamaki
left a comment
There was a problem hiding this comment.
looks good to me; testing works as explained
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Reverts changes from #3771
Instead changes the max rev setting for events received from the backend to filter out server generated events
Also changes how we send max rev from the backend to do the same filtering
Adds use of the visibility API for the active channel tracking so that switching back to a browser tab is sufficient to mark a channel as active, rather than needing to click inside the window
Manual verification steps performed
Do an import of a folder
Ensure that clicking into the folder properly lists it
Open a different browser session
Initiate an import into the same channel in that session
Click back to the window/tab of the original session and ensure the copied item appears once the copy completes
References
Fixes issue reported here: #3771 (comment)